Profil page #155
Merged
Profil page #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rtrembecky
approved these changes
Nov 11, 2023
Comment on lines
+19
to
+22
| <Typography sx={{fontSize: '1.875rem'}}> | ||
| <span className={styles.label}>{label}</span> | ||
| {value} | ||
| </Typography> |
There was a problem hiding this comment.
asi to po #162 bude Stack horizontal gap 1 a Typography osobitne na label a value, ale v poho nateraz
| <ProfileLine label={'meno'} value={profile?.first_name + ' ' + profile?.last_name} /> | ||
| <ProfileLine label={'e-mail'} value={profile?.email} /> | ||
| <ProfileLine label={'škola'} value={profile?.school.verbose_name} /> | ||
| <ProfileLine label={'ročník'} value={`${profile?.grade_name}`} /> |
There was a problem hiding this comment.
zbytocna konverzia na string. inak ten default ze || '-' netreba pri email/school/grade?
| @@ -0,0 +1,12 @@ | |||
| import {NextPage} from 'next' | |||
There was a problem hiding this comment.
treba este matik a malynar stranky
Matushl
force-pushed
the
matush/editacia-profilu
branch
from
fd7b8da to
be3f592
Compare
Matushl
force-pushed
the
matush/editacia-profilu
branch
from
be3f592 to
1ef4400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first part of #56